feat: support includes for services #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 61.09% 60.56% -0.54%
==========================================
Files 2 2
Lines 910 923 +13
==========================================
+ Hits 556 559 +3
- Misses 354 364 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
richm
force-pushed
the
feat-support-includes
branch
from
d9c05ee to
6de9b7a
Compare
Contributor
Author
|
[citest] |
Feature: Allow for includes to be specified for services. Includes are described at https://firewalld.org/documentation/man-pages/firewalld.service.html Reason: This makes firewalld services more explicit and easier / quicker to read when there are many non-standard ports. Result: Users can specify other services to include when creating and setting services. Signed-off-by: Rich Megginson <[email protected]> Fixes linux-system-roles#255
richm
force-pushed
the
feat-support-includes
branch
from
6de9b7a to
ebe46b6
Compare
Contributor
Author
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Allow for includes to be specified for services.
Includes are described at https://firewalld.org/documentation/man-pages/firewalld.service.html
Reason: This makes firewalld services more explicit and easier / quicker
to read when there are many non-standard ports.
Result: Users can specify other services to include when creating
and setting services.
Signed-off-by: Rich Megginson [email protected]
Fixes #255